Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

credential_process DefaultBufSize too small #2334

Closed
jmassara opened this issue Dec 6, 2018 · 2 comments
Closed

credential_process DefaultBufSize too small #2334

jmassara opened this issue Dec 6, 2018 · 2 comments

Comments

@jmassara
Copy link
Contributor

jmassara commented Dec 6, 2018 •
edited
Loading

Please fill out the sections below to help us address your issue.

Version of AWS SDK for Go?

v1.16.0

Version of Go (go version)?

go version go1.11.2 darwin/amd64

What issue did you see?

When using the new credential_process feature, it always fails with:

failed of credential_process output: <snippet of json from process>\ncaused by: unexpected end of JSON input"

Steps to reproduce

I have a custom CLI that I executed as follows to take advantage of credential_process:

$ AWS_SDK_LOAD_CONFIG=1 myCli

The problem is https://github.com/aws/aws-sdk-go/blob/master/aws/credentials/processcreds/provider.go#L145 is too small.
jmassara added a commit to jmassara/aws-sdk-go that referenced this issue Dec 6, 2018
@jmassara
Increase DefaultBufSize
d0315f5 
The current buffer size is too small to account for the size of the
session token along with the other values. The size I typically see is
587, however I increased the default size to 1024, which seems pretty
reasonable.

Addresses aws#2334
@jmassara jmassara mentioned this issue Dec 6, 2018
Closed
@jasdel jasdel closed this as completed in 89ebd3a Dec 6, 2018
@jasdel
Copy link
Contributor

jasdel commented Dec 6, 2018

Thanks for reporting this issue @jmassara. We've merged in a fix in, #2329

@jmassara
Copy link
Contributor Author

jmassara commented Dec 7, 2018

@jasdel sorry for the extra PR, I searched issues and not pull requests when checking early. My bad.. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jasdel @jmassara