Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible documentation issue: TTL required for ChangeResourceRecordSet #324

Closed
beetree opened this issue Jul 22, 2015 · 1 comment
Closed

Comments

@beetree
Copy link

beetree commented Jul 22, 2015

This request (awsutilStringValue-printed) fails:

{
  ChangeBatch: {
    Changes: [{
        Action: "UPSERT",
        ResourceRecordSet: {
          Name: "test.eleet.io",
          ResourceRecords: [{
              Value: "1.2.3.4"
            }],
          Type: "A"
        }
      }]
  },
  HostedZoneID: "Z1D7XUUU1KCTJJ"
}

InvalidInput: Invalid request
        status code: 400, request id: [704348a5-30a6-11e5-bf66-03665cd893ce]

Whereas this request works:

{
  ChangeBatch: {
    Changes: [{
        Action: "UPSERT",
        ResourceRecordSet: {
          Name: "test.eleet.io",
          ResourceRecords: [{
              Value: "1.2.3.4"
            }],
          TTL: 60,
          Type: "A"
        }
      }]
  },
  HostedZoneID: "Z1D7XUUU1KCTJJ"
}

{
  ChangeInfo: {
    ID: "/change/C11AIRX96SV181",
    Status: "PENDING",
    SubmittedAt: 2015-07-22 19:19:07.117 +0000 UTC
  }
}

But the documentation states that TTL is not required.

I hope this saves someone else some debugging time...

/b3

@lsegal
Copy link
Contributor

lsegal commented Jul 22, 2015

The issue here is that TTL is conditionally required depending on what other parameters are provided in the operation, see the Route53 API Reference documentation for more information. Specifically, TTL is not required for alias resource record sets, which is why it is not marked as required. It seems like we should potentially sync some of that extra API documentation down to our SDKs, though.

@beetree beetree closed this as completed Jul 29, 2015
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
Updates the Location returned value of S3 Upload's Multipart
UploadOutput type to be consistent with single part upload URL. This
update also brings the multipart upload Location inline with the S3
object URLs created by the SDK.

Fix aws#323
V2 Port aws#2453
skotambkar pushed a commit to skotambkar/aws-sdk-go that referenced this issue May 20, 2021
Services
===
* Synced the V2 SDK with latest AWS service API definitions.
* Fixes [aws#341](aws/aws-sdk-go-v2#341)
* Fixes [aws#342](aws/aws-sdk-go-v2#342)

SDK Breaking Changes
===
* `aws`: Add default HTTP client instead of http.DefaultClient/Transport ([aws#315](aws/aws-sdk-go-v2#315))
  * Adds a new BuildableHTTPClient type to the SDK's aws package. The type uses the builder pattern with immutable changes. Modifications to the buildable client create copies of the client.  Adds a HTTPClient interface to the aws package that the SDK will use as an abstraction over the specific HTTP client implementation. The SDK will default to the BuildableHTTPClient, but a *http.Client can be also provided for custom configuration.  When the SDK's aws.Config.HTTPClient value is a BuildableHTTPClient the SDK will be able to use API client specific request timeout options.
  * Fixes [aws#279](aws/aws-sdk-go-v2#279)
  * Fixes [aws#269](aws/aws-sdk-go-v2#269)

SDK Enhancements
===
* `service/s3/s3manager`: Update S3 Upload Multipart location ([aws#324](aws/aws-sdk-go-v2#324))
  * Updates the Location returned value of S3 Upload's Multipart UploadOutput type to be consistent with single part upload URL. This update also brings the multipart upload Location inline with the S3 object URLs created by the SDK.
  * Fixes [aws#323](aws/aws-sdk-go-v2#323)
  * V2 Port [aws#2453](aws#2453)

SDK Bugs
===
* `private/model`: Handles empty map vs unset map behavior in send request ([aws#337](aws/aws-sdk-go-v2#337))
  * Updated shape marshal model to handle the empty map vs nil map behavior. Adding a test case to assert behavior when a user sends an empty map vs nil map.
  * Fix [aws#332](aws/aws-sdk-go-v2#332)
* `service/rds`: Fix presign URL for same region ([aws#331](aws/aws-sdk-go-v2#331))
  * Fixes RDS no-autopresign URL for same region issue for aws-sdk-go-v2. Solves the issue by making sure that the presigned URLs are not created, when the source and destination regions are the same. Added and updated the tests accordingly.
  * Fix [aws#271](aws/aws-sdk-go-v2#271)
* `private/protocola/json/jsonutil`: Fix Unmarshal map[string]bool ([aws#320](aws/aws-sdk-go-v2#320))
  * Fixes the JSON unmarshaling of maps of bools. The unmarshal case was missing the condition for bool value, in addition the bool pointer.
  * Fix [aws#319](aws/aws-sdk-go-v2#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants