-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/s3control: DeleteBucketInput Modified After Use #3583
Labels
bug
This issue is a bug.
Comments
Hi @bflad , |
Merged
aws-sdk-go-automation
pushed a commit
that referenced
this issue
Oct 15, 2020
=== ### Service Client Updates * `service/accessanalyzer`: Updates service API and documentation * `service/budgets`: Updates service API, documentation, and paginators * This release introduces AWS Budgets Actions, allowing you to define an explicit response(or set of responses) to take when your budget exceeds it's action threshold. * `service/ce`: Updates service API and documentation * `service/dms`: Updates service API and documentation * When creating Endpoints, Replication Instances, and Replication Tasks, the feature provides you the option to specify friendly name to the resources. * `service/glue`: Updates service documentation * API Documentation updates for Glue Get-Plan API * `service/groundstation`: Updates service API and documentation * `service/iot`: Updates service API and documentation * Add new variable, lastStatusChangeDate, to DescribeDomainConfiguration API * `service/macie2`: Updates service API and documentation * `service/rds`: Updates service API and documentation * Return tags for all resources in the output of DescribeDBInstances, DescribeDBSnapshots, DescribeDBClusters, and DescribeDBClusterSnapshots API operations. * `service/rekognition`: Updates service API and documentation * This SDK Release introduces new API (DetectProtectiveEquipment) for Amazon Rekognition. This release also adds ServiceQuotaExceeded exception to Amazon Rekognition IndexFaces API. * `service/ssm`: Updates service API and documentation * This Patch Manager release now supports searching for available packages from Amazon Linux and Amazon Linux 2 via the DescribeAvailablePatches API. * `service/transfer`: Updates service API and documentation * Add support to associate VPC Security Groups at server creation. * `service/workmail`: Updates service API and documentation * Add CreateOrganization and DeleteOrganization API operations. * `service/workspaces`: Updates service documentation * Documentation updates for WorkSpaces * `service/xray`: Updates service API, documentation, and paginators * Enhancing CreateGroup, UpdateGroup, GetGroup and GetGroups APIs to support configuring X-Ray Insights Notifications. Adding TraceLimit information into X-Ray BatchGetTraces API response. ### SDK Bugs * `s3control`: Fixes bug in SDK that caused input for certain s3control operation to be modified, when using ARNs. ([#3595](#3595)) * Fixes [#3583](#3583).
aws-sdk-go-automation
added a commit
that referenced
this issue
Oct 15, 2020
Release v1.35.8 (2020-10-15) === ### Service Client Updates * `service/accessanalyzer`: Updates service API and documentation * `service/budgets`: Updates service API, documentation, and paginators * This release introduces AWS Budgets Actions, allowing you to define an explicit response(or set of responses) to take when your budget exceeds it's action threshold. * `service/ce`: Updates service API and documentation * `service/dms`: Updates service API and documentation * When creating Endpoints, Replication Instances, and Replication Tasks, the feature provides you the option to specify friendly name to the resources. * `service/glue`: Updates service documentation * API Documentation updates for Glue Get-Plan API * `service/groundstation`: Updates service API and documentation * `service/iot`: Updates service API and documentation * Add new variable, lastStatusChangeDate, to DescribeDomainConfiguration API * `service/macie2`: Updates service API and documentation * `service/rds`: Updates service API and documentation * Return tags for all resources in the output of DescribeDBInstances, DescribeDBSnapshots, DescribeDBClusters, and DescribeDBClusterSnapshots API operations. * `service/rekognition`: Updates service API and documentation * This SDK Release introduces new API (DetectProtectiveEquipment) for Amazon Rekognition. This release also adds ServiceQuotaExceeded exception to Amazon Rekognition IndexFaces API. * `service/ssm`: Updates service API and documentation * This Patch Manager release now supports searching for available packages from Amazon Linux and Amazon Linux 2 via the DescribeAvailablePatches API. * `service/transfer`: Updates service API and documentation * Add support to associate VPC Security Groups at server creation. * `service/workmail`: Updates service API and documentation * Add CreateOrganization and DeleteOrganization API operations. * `service/workspaces`: Updates service documentation * Documentation updates for WorkSpaces * `service/xray`: Updates service API, documentation, and paginators * Enhancing CreateGroup, UpdateGroup, GetGroup and GetGroups APIs to support configuring X-Ray Insights Notifications. Adding TraceLimit information into X-Ray BatchGetTraces API response. ### SDK Bugs * `s3control`: Fixes bug in SDK that caused input for certain s3control operation to be modified, when using ARNs. ([#3595](#3595)) * Fixes [#3583](#3583).
|
bflad
added a commit
to hashicorp/terraform-provider-aws
that referenced
this issue
Oct 16, 2020
bflad
added a commit
to hashicorp/terraform-provider-aws
that referenced
this issue
Oct 16, 2020
bflad
added a commit
to hashicorp/terraform-provider-aws
that referenced
this issue
Oct 27, 2020
* New Resource: aws_s3control_bucket Reference: #15413 Output from acceptance testing: ``` --- PASS: TestAccAWSS3ControlBucket_basic (58.52s) --- PASS: TestAccAWSS3ControlBucket_disappears (63.94s) --- SKIP: TestAccAWSS3ControlBucket_Tags (0.00s) ``` * resource/aws_s3control_bucket: Remove workaround fixed in AWS Go SDK Reference: aws/aws-sdk-go#3583 * Update aws/resource_aws_s3control_bucket_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Confirm by changing [ ] to [x] below to ensure that it's a bug:
Describe the bug
The new S3 on Outposts functionality released in version 1.35.0 of the AWS Go SDK requires customizations to handle routing S3 Control requests to the correct endpoint. These customization seem to be modifying the operation inputs (at least the
DeleteBucketInput
type), which is unexpected behavior compared to other AWS Go SDK service handling and especially causes errors with thes3control
service since it modifies theBucket
parameter in a way that breaks downstream usage such as manually retrying on error.Version of AWS SDK for Go?
Version of Go (
go version
)?To Reproduce (observed behavior)
Output:
Expected behavior
Additional context
The
Bucket
being changed from the ARN to the name causes the HTTP headers and endpoint routing to break in real world usage on second use. Real world logs:The text was updated successfully, but these errors were encountered: