service/s3control: GetAccessPointPolicy S3 on Outposts Endpoint Customization Not Occurring

[bflad]

Confirm by changing [ ] to [x] below to ensure that it's a bug:

• I've gone though Developer Guide and API reference
• I've checked AWS Forums and StackOverflow for answers
• I've searched for previous similar issues and didn't find any solution

Describe the bug

When issuing the GetAccessPointPolicy call, passing an ARN in the Name field is not transforming the request to contain the proper HTTP headers (e.g. Host: s3-outposts.us-west-2.amazonaws.com and X-Amz-Outpost-Id) for S3 on Outposts.

Version of AWS SDK for Go?

v1.35.5

Version of Go (go version)?

go version go1.15.2 darwin/amd64

To Reproduce (observed behavior)

_, err := conn.GetAccessPointPolicy(&s3control.GetAccessPointPolicyInput{
	AccountId: aws.String("123456789012"),
	Name:      aws.String("arn:aws:s3-outposts:us-west-2:12345679012:outpost/op-1234567890123456/accesspoint/example"),
})

2020/10/15 13:30:51 [DEBUG] [aws-sdk-go] DEBUG: Request S3 Control/GetAccessPointPolicy Details:
---[ REQUEST POST-SIGN ]-----------------------------
GET /v20180820/accesspoint/arn%3Aaws%3As3-outposts%3Aus-west-2%3A123456789012%3Aoutpost%2Fop-0cc27b83880c7d8e9%2Faccesspoint%2Fexample/policy HTTP/1.1
Host: 123456789012.s3-control.us-west-2.amazonaws.com
User-Agent: aws-sdk-go/1.35.2 (go1.14.9; darwin; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.13.4 (+https://www.terraform.io)
...
X-Amz-Account-Id: 123456789012
X-Amz-Content-Sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855
X-Amz-Date: 20201015T173051Z

Which results in:

2020/10/15 13:30:52 [DEBUG] [aws-sdk-go] <?xml version="1.0" encoding="UTF-8"?>
<ErrorResponse><Error><Code>InvalidURI</Code><Message>Couldn't parse the specified URI.</Message><URI>accesspoint/arn:aws:s3-outposts:us-west-2:12345678012:outpost/op-1234567890123456/accesspoint/example/policy</URI></Error><RequestId>1378EFEEB028D62D</RequestId><HostId>C+McQGMbNY/GE/agmaZQ8pfiMcP4FVbHz62LckFp1NWAQOOJLxY8PEaQInDVAjkkcpSZ+lkxEU8=</HostId></ErrorResponse>

Expected behavior

Working behavior similar to GetAccessPoint:

_, err := conn.GetAccessPoint(&s3control.GetAccessPointInput{
	AccountId: aws.String("123456789012"),
	Name:      aws.String("arn:aws:s3-outposts:us-west-2:12345679012:outpost/op-1234567890123456/accesspoint/example"),
})

2020/10/15 13:30:51 [DEBUG] [aws-sdk-go] DEBUG: Request S3 Control/GetAccessPoint Details:
---[ REQUEST POST-SIGN ]-----------------------------
GET /v20180820/accesspoint/example HTTP/1.1
Host: s3-outposts.us-west-2.amazonaws.com
User-Agent: aws-sdk-go/1.35.2 (go1.14.9; darwin; amd64) APN/1.0 HashiCorp/1.0 Terraform/0.13.4 (+https://www.terraform.io)
...
X-Amz-Account-Id: 123456789012
X-Amz-Date: 20201015T173051Z
X-Amz-Outpost-Id: op-1234567890123456

With a successful response.

Additional context

These lines look like they are missing the Input suffix in the s3control customizations:

aws-sdk-go/private/model/api/customization_passes.go

Lines 225 to 232 in 32ff04d

	// List of input shapes that use accesspoint names as arnable fields
	accessPointNameArnables := map[string]struct{}{
	"GetAccessPointInput": {},
	"DeleteAccessPointInput": {},
	"PutAccessPointPolicy": {},
	"GetAccessPointPolicy": {},
	"DeleteAccessPointPolicy": {},
	}

[bflad]

Maybe this will fix it: #3599

[KaibaLopez]

Hi @skotambkar ,
The PR has been accepted and merged so I'll be closing this issue, thanks for bringing it up and submitting the PR.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.