Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/rds/rdsutils: example and updating rdsutils to not require scheme #1256

Merged
merged 1 commit into from
May 16, 2017
Merged

service/rds/rdsutils: example and updating rdsutils to not require scheme #1256

merged 1 commit into from
May 16, 2017

Conversation

xibz
Copy link
Contributor

@xibz xibz commented May 9, 2017

No description provided.

@xibz xibz requested a review from jasdel May 9, 2017 16:56
@xibz xibz changed the title Adding example for rdsutils and also adding scheme if one wasn't prov… service/rds/rdsutils: Adding example for rdsutils and also adding scheme if one wasn't prov… May 9, 2017
@xibz xibz changed the title service/rds/rdsutils: Adding example for rdsutils and also adding scheme if one wasn't prov… service/rds/rdsutils: example and updating rdsutils to not require scheme May 9, 2017
jasdel
jasdel suggested changes May 9, 2017
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just need the build tag, and should update Usage section with go -tags example run ...

example/service/rds/rdsutils/authentication/iam_authentication.go
@@ -0,0 +1,45 @@
package main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need // +build example build tag

@xibz xibz force-pushed the rds_example branch 2 times, most recently from 14a360f to 03c2121 Compare May 9, 2017 17:28
@xibz xibz mentioned this pull request May 9, 2017
Closed
@jasdel
Copy link
Contributor

jasdel commented May 10, 2017

For the testing error:
cannot find package "github.com/go-sql-driver/mysql"

probably want to add a skip build flag to the file so it won't be tested because of the external dependency. Something like:

// +build example,skip

jasdel
jasdel approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@jasdel jasdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xibz xibz merged commit 974d6cf into aws:master May 16, 2017
@xibz xibz deleted the rds_example branch May 30, 2017 23:42
@diehlaws diehlaws added needs-review This issue or pull request needs review from a core team member. and removed review-needed labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasdel jasdel jasdel approved these changes

Assignees
No one assigned
Labels
needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xibz @jasdel @diehlaws