aws/request: Do not treat LimitExceededException as throttle error #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LimitExceededException error code should not be treated as a throttling condition. This error code implies that resources are exhausted or too many tasks are being attempted at once. The SDK does not have the information it needs to distinguish between the resources exhausted and too many tasks attempted at once. This logic is best implemented by user applications as they will have the most context about what is being attempted. To add custom retry with this error code a custom implementation of the "request.Retryer" interface should be used. Fix aws#1271
xibz
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LimitExceededException error code should not be treated as a
throttling condition. This error code implies that resources are
exhausted or too many tasks are being attempted at once. The SDK does
not have the information it needs to distinguish between the resources
exhausted and too many tasks attempted at once.
This logic is best implemented by user applications as they will have
the most context about what is being attempted.
To add custom retry with this error code a custom implementation of the
request.Retryerinterface should be used.Fix #1271