Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws/session: Use HTTP_PROXY environment variable when AWS_CA_BUNDLE is specified #2343

Merged
merged 3 commits into from
Mar 1, 2019

Conversation

diehlaws
Copy link
Contributor

Ensures HTTP_PROXY environment variable is read when specifying AWS_CA_BUNDLE environment variable.

Fix #2287

@diehlaws diehlaws requested a review from jasdel December 10, 2018 21:48
@diehlaws diehlaws added needs-review This issue or pull request needs review from a core team member. and removed review-needed labels Jan 4, 2019
@jasdel jasdel force-pushed the fix/proxy branch 2 times, most recently from a3a53d5 to 9bfd518 Compare March 1, 2019 00:10
@jasdel jasdel merged commit 2c864ae into aws:master Mar 1, 2019
jasdel added a commit that referenced this pull request Mar 1, 2019
Adds #2456 and #2343 to pending change for next release.
@aws-sdk-go-automation aws-sdk-go-automation mentioned this pull request Mar 1, 2019
@diehlaws diehlaws deleted the fix/proxy branch August 5, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This issue or pull request needs review from a core team member. needs-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants