Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify struct, map, array and slice literals #268

Merged
merged 1 commit into from
Jun 5, 2015
Merged

Conversation

mrekucci
Copy link
Contributor

@mrekucci mrekucci commented Jun 5, 2015

Such a simplified formatting helps to improve code readability.

@lsegal
Copy link
Contributor

lsegal commented Jun 5, 2015

Thanks! However, most of those files touched are auto-generated, so we would need to fix the generators that create these files in order to accept this patch.

Running make generate and make generate-protocol-test should show you what's been overwritten.

@mrekucci
Copy link
Contributor Author

mrekucci commented Jun 5, 2015

There is no magic behind this PR. I just run the gofmt -s -w command at the top of the repository.

@mrekucci
Copy link
Contributor Author

mrekucci commented Jun 5, 2015

Oh, I didn't know that. Is there a good reason to keep such a generated files in the repository?

@lsegal
Copy link
Contributor

lsegal commented Jun 5, 2015

Go generate is never run automatically by go build, go get, go test, and so on. It must be run explicitly.

Unfortunately because of this rule in go generate.

Such a simplified formatting helps to improve code readability.
@mrekucci
Copy link
Contributor Author

mrekucci commented Jun 5, 2015

I fixed the commit. I took away the files which are generated. I hope it's ok now.

lsegal added a commit that referenced this pull request Jun 5, 2015
Simplify struct, map, array and slice literals
@lsegal lsegal merged commit 94529fb into aws:master Jun 5, 2015
jasdel added a commit that referenced this pull request Jun 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants