private/mode/api: Add codegen typed Errors for RESTJSON and JSONRPC APIs #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasdel
force-pushed
the
feat/GeneratedTypedErrors
branch
2 times, most recently
from
b0f208a to
d081b04
Compare
jasdel
added
needs-review
jasdel
force-pushed
the
feat/GeneratedTypedErrors
branch
2 times, most recently
from
5d59e7e to
8eb1550
Compare
skotambkar
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
Comment on lines
+24
to
+28
| func NewUnmarshalErrorHandler(unmarshaler ErrorUnmarshaler) *UnmarshalErrorHandler { | ||
| return &UnmarshalErrorHandler{ | ||
| unmarshaler: unmarshaler, | ||
| } | ||
| } |
There was a problem hiding this comment.
constructor not needed here
There was a problem hiding this comment.
The purpose of these constructors is to reinforce the idea that the passed in parameters is a required parameter and the type must be created with its value. When doing struct initialization there is no clear signal what if anything is required members. This is the reason constructors may be preferred for initializing a type.
skotambkar
reviewed
Jan 9, 2020
skmcgrail
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
skotambkar
reviewed
Jan 9, 2020
skotambkar
suggested changes
Jan 9, 2020
jasdel
force-pushed
the
feat/GeneratedTypedErrors
branch
from
f68484e to
3feee2a
Compare
Adds code generated error types for APIs using RESTJSON and JSONRPC protocol, and modeled errors. This adds generated error types that can be typed asserted to in order to read error values in addition to Code and Message.
jasdel
force-pushed
the
feat/GeneratedTypedErrors
branch
from
d30a2ab to
dc34276
Compare
skmcgrail
approved these changes
Jan 10, 2020
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds code generated error types for APIs using RESTJSON and JSONRPC protocol, and modeled errors. This adds generated error types that can be typed asserted to in order to read error values in addition to Code and Message.
TODO: