-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/s3/s3manager: Clarify documentation and behavior of GetBucketRegion #3428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Region Updates the documentation for GetBucketRegion's behavior with regard to default configuration for path style addressing. Provides examples how to override this behavior. Updates the GetBucketRegion utility to not require a region hint when the session or client was configured with a custom endpoint URL.
skotambkar
reviewed
Jul 16, 2020
skotambkar
approved these changes
Jul 16, 2020
Merged
aws-sdk-go-automation
pushed a commit
that referenced
this pull request
Jul 17, 2020
=== ### Service Client Updates * `service/application-autoscaling`: Updates service documentation * `service/appsync`: Updates service documentation * `service/connect`: Updates service API and documentation * `service/ec2`: Updates service API and documentation * Documentation updates for EC2 * `service/elasticbeanstalk`: Updates service waiters and paginators * Add waiters for `EnvironmentExists`, `EnvironmentUpdated`, and `EnvironmentTerminated`. Add paginators for `DescribeEnvironmentManagedActionHistory` and `ListPlatformVersions`. * `service/macie2`: Updates service API, documentation, and paginators ### SDK Enhancements * `service/s3/s3manager`: Clarify documentation and behavior of GetBucketRegion ([#3428](#3428)) * Updates the documentation for GetBucketRegion's behavior with regard to default configuration for path style addressing. Provides examples how to override this behavior. * Updates the GetBucketRegion utility to not require a region hint when the session or client was configured with a custom endpoint URL. * Related to [#3115](#3115) * `service/s3`: Add failsafe handling for unknown stream messages * Adds failsafe handling for receiving unknown stream messages from an API. A `<streamName>UnknownEvent` type will encapsulate the unknown message received from the API. Where `<streamName>` is the name of the API's stream, (e.g. S3's `SelectObjectContentEventStreamUnknownEvent`).
aws-sdk-go-automation
added a commit
that referenced
this pull request
Jul 17, 2020
Release v1.33.7 (2020-07-17) === ### Service Client Updates * `service/application-autoscaling`: Updates service documentation * `service/appsync`: Updates service documentation * `service/connect`: Updates service API and documentation * `service/ec2`: Updates service API and documentation * Documentation updates for EC2 * `service/elasticbeanstalk`: Updates service waiters and paginators * Add waiters for `EnvironmentExists`, `EnvironmentUpdated`, and `EnvironmentTerminated`. Add paginators for `DescribeEnvironmentManagedActionHistory` and `ListPlatformVersions`. * `service/macie2`: Updates service API, documentation, and paginators ### SDK Enhancements * `service/s3/s3manager`: Clarify documentation and behavior of GetBucketRegion ([#3428](#3428)) * Updates the documentation for GetBucketRegion's behavior with regard to default configuration for path style addressing. Provides examples how to override this behavior. * Updates the GetBucketRegion utility to not require a region hint when the session or client was configured with a custom endpoint URL. * Related to [#3115](#3115) * `service/s3`: Add failsafe handling for unknown stream messages * Adds failsafe handling for receiving unknown stream messages from an API. A `<streamName>UnknownEvent` type will encapsulate the unknown message received from the API. Where `<streamName>` is the name of the API's stream, (e.g. S3's `SelectObjectContentEventStreamUnknownEvent`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the documentation for GetBucketRegion's behavior with regard to default configuration for path style addressing. Provides examples how to override this behavior.
Updates the GetBucketRegion utility to not require a region hint when the session or client was configured with a custom endpoint URL.
Related to #3115