Add WithUseFIPSEndpoint to aws.Config

[reedloden]

The ability to chain UseFIPSEndpoint was missing.

[reedloden]

@lucix-aws What's the right way to get review on this?

[lucix-aws]

@reedloden This is fine but it needs to take a bool like WithUseDualStack does since it's an explicit call.

[reedloden]

@reedloden This is fine but it needs to take a bool like WithUseDualStack does since it's an explicit call.

UseFIPSEndpoint is not a boolean, though. It's an enum. See

aws-sdk-go/aws/config.go

Lines 241 to 242 in 15ccb94

	// UseFIPSEndpoint specifies the resolver must resolve a FIPS endpoint.
	UseFIPSEndpoint endpoints.FIPSEndpointState

and

aws-sdk-go/aws/endpoints/endpoints.go

Lines 32 to 44 in 15ccb94

	// FIPSEndpointState is a constant to describe the FIPS endpoint resolution behavior.
	type FIPSEndpointState uint
	const (
	// FIPSEndpointStateUnset is the default value behavior for FIPS endpoint resolution.
	FIPSEndpointStateUnset FIPSEndpointState = iota
	// FIPSEndpointStateEnabled enables FIPS endpoint resolution for service endpoints.
	FIPSEndpointStateEnabled
	// FIPSEndpointStateDisabled disables FIPS endpoint resolution for endpoints.
	FIPSEndpointStateDisabled
	)

. Need to be able to explicitly set it to whichever state is needed.

UseDualStack does take a bool, but note that it's deprecated. UseDualStackEndpoint is its replacement, and it takes an enum as well.

[lucix-aws]

Yes, Config.UseDualStack is deprecated, but its WithUseDualStack that takes a bool (again, since it's something you'd explicitly call) is not. That's what I'm looking to match here API-wise.

[lucix-aws]

(see above)

[reedloden]

Yes, Config.UseDualStack is deprecated, but its WithUseDualStack that takes a bool (again, since it's something you'd explicitly call) is not. That's what I'm looking to match here API-wise.

Ok. I was trying to provide all three options to users (to allow them to even unset it if it had been previously set), but this will still be an improvement. Updated based on what I believe you're looking for.

[lucix-aws]

Yes, Config.UseDualStack is deprecated, but its WithUseDualStack that takes a bool (again, since it's something you'd explicitly call) is not. That's what I'm looking to match here API-wise.

Ok. I was trying to provide all three options to users (to allow them to even unset it if it had been previously set), but this will still be an improvement. Updated based on what I believe you're looking for.

Yeah I see where you were coming from. The whole State thing we have for a few fields is an unfortunate legacy decision we used to disambiguate between an unset value and the zero value, it's really not at all necessary given the default for these settings is usually false, but it's established.