fix for issue #783 #784
Merged
fix for issue #783 #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two more |
|
Thanks for creating the PR @ColourboxDevelopment. The change looks good and I verified it locally. The other customizations are specific S3. The URI path escaping is specific to S3, and Glacier doesn't support the "UNSIGNED-PAYLOAD" body hash substitution for pre-signed requests. |
jasdel
added a commit
that referenced
this pull request
Aug 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in commit bae4e52 (relating to issue #743) that broke glacier's UploadMultpartPart. I'm not 100% sure what's going on here, but it appears that glacier has the same signer-v4 exceptions as s3?
Fix #783