Skip to content

Fix CRT client builder #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

Fix CRT client builder #2349

merged 1 commit into from
Mar 26, 2021
+49 −18

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Mar 26, 2021

Description

  • Return the correct type from builder methods
  • Make max thorughput and part size nullable

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@dagnir
Fix CRT S3 Client builder
d3ed7ea 
 - Return the correct type from builder methods
 - Make max throughput and part size nullable
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 26, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dagnir dagnir merged commit 3f4adb3 into aws:feature/master/transfermanager Mar 26, 2021
@dagnir dagnir deleted the fix-builder branch March 26, 2021 20:26
aws-sdk-java-automation pushed a commit that referenced this pull request Jan 26, 2023
@davidh44
Merge pull request #2349 from aws/staging/6696d63c-d0a1-4d69-b7d8-656…
6fcc677 
…072434ba5

Pull request: release <- staging/6696d63c-d0a1-4d69-b7d8-656072434ba5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cenedhryn cenedhryn cenedhryn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dagnir @cenedhryn