Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the use of CrtS3RuntimeException in tests #4635

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Remove the use of CrtS3RuntimeException in tests #4635

merged 1 commit into from
Oct 25, 2023

Conversation

zoewangg
Copy link
Contributor

Motivation and Context

Remove the use of CrtS3RuntimeException in our tests. This class is to be removed in awslabs/aws-crt-java#700

@zoewangg zoewangg requested a review from a team as a code owner October 25, 2023 18:27
@zoewangg zoewangg enabled auto-merge (squash) October 25, 2023 18:51
@zoewangg zoewangg disabled auto-merge October 25, 2023 18:51
@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

84.7% 84.7% Coverage
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@zoewangg zoewangg merged commit cffbc7a into master Oct 25, 2023
7 of 8 checks passed
@zoewangg zoewangg deleted the zoewang/removeCrtS3RuntimeException branch October 25, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Applin L-Applin L-Applin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoewangg @L-Applin