-
Notifications
You must be signed in to change notification settings - Fork 912
Adding functionality to config preferred authschemeProvider #6083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
362e5f3
to
f18fcc2
Compare
12 tasks
zoewangg
previously requested changes
May 28, 2025
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Show resolved
Hide resolved
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...rc/test/java/software/amazon/awssdk/services/multiauth/AuthSchemePreferenceProviderTest.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/awssdk/codegen/poet/auth/scheme/PreferredAuthSchemeProviderSpec.java
Show resolved
Hide resolved
...in/java/software/amazon/awssdk/codegen/poet/auth/scheme/PreferredAuthSchemeProviderSpec.java
Show resolved
Hide resolved
...rc/test/java/software/amazon/awssdk/services/multiauth/AuthSchemePreferenceProviderTest.java
Outdated
Show resolved
Hide resolved
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Outdated
Show resolved
Hide resolved
L-Applin
requested changes
May 28, 2025
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Show resolved
Hide resolved
.../amazon/awssdk/codegen/poet/auth/scheme/query-endpoint-auth-params-auth-scheme-provider.java
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceProvider.java
Outdated
Show resolved
Hide resolved
...in/java/software/amazon/awssdk/codegen/poet/auth/scheme/PreferredAuthSchemeProviderSpec.java
Show resolved
Hide resolved
RanVaknin
commented
May 29, 2025
...ces/software/amazon/awssdk/codegen/poet/auth/scheme/test-preferred-auth-scheme-provider.java
Outdated
Show resolved
Hide resolved
This reverts commit 141b9d6.
zoewangg
reviewed
May 30, 2025
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Outdated
Show resolved
Hide resolved
...st/resources/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-provider.java
Outdated
Show resolved
Hide resolved
...es/software/amazon/awssdk/codegen/poet/auth/scheme/query-auth-scheme-preferred-provider.java
Show resolved
Hide resolved
Dismissing to unblock the change since I'm OOTO.
L-Applin
approved these changes
Jun 2, 2025
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceResolver.java
Outdated
Show resolved
Hide resolved
...aws-core/src/main/java/software/amazon/awssdk/awscore/auth/AuthSchemePreferenceResolver.java
Outdated
Show resolved
Hide resolved
…h/AuthSchemePreferenceResolver.java Co-authored-by: Olivier L Applin <olapplin@amazon.com>
…h/AuthSchemePreferenceResolver.java Co-authored-by: Olivier L Applin <olapplin@amazon.com>
L-Applin
approved these changes
Jun 3, 2025
zoewangg
approved these changes
Jun 4, 2025
...rc/test/java/software/amazon/awssdk/services/multiauth/AuthSchemePreferenceResolverTest.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api-surface-area-approved-by-team
Indicate API surface area introduced by this PR has been approved by team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously, when multiple auth schemes were available for an operation, the SDK would choose the first one defined in the service model. This PR implements the auth scheme preference configuration that allows users to specify their preferred authentication schemes in order of preference when multiple auth schemes are supported.
Example usage:
Modifications
[Modified] client builders to read and apply auth scheme preferences
[Modified] the auth scheme resolution logic to respect user preferences while maintaining backward compatibility
[Added]
AuthSchemePreferenceProvider
class to resolve auth scheme preferences from various sources:aws.authSchemePreference
)AWS_AUTH_SCHEME_PREFERENCE
)auth_scheme_preference
)[Added] code generation support through PreferredAuthSchemeProviderSpec to generate service-specific auth scheme providers
Testing
AuthSchemePreferenceProviderTest
verifies proper parsing of auth scheme preferences from different formats (spaces, tabs, etc.)PreferredAuthSchemeProviderTest
to test the reordering of auth schemes according to preferencescomprehensive test cases for preference resolution from multiple sources, verifying proper precedence:
Stubbed functional test with mock services to verify the selected auth scheme matches the expected preference in actual requests