Optimize Endpoint Rule Standard library functions #6622
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Optimize Endpoint Rule Standard library functions
Motivation and Context
One of the largest costs when resolving endpoints is in calling the various standard library functions. This PR improves performance by optimizing a few of the most common/highest cost functions. See benchmark results below testing section.
Modifications
Testing
All of the rules standard library functions are covered by existing endpoint/codegeneration tests.
Benchmarks
Headline benchmark: All S3 non-error cases:
We see a 1.2x improvement in overall endpoint resolution!
Substring: 2.9x faster
parseArn: 2.7x faster
isValidHostLabel: 10x faster
isVirtualHostableS3Bucket: 17x faster
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License