Please do not use underscores as Java identifiers in source code

[vemv]

Describe the bug

The java source code of these libraries, as distributed in e.g. aws-java-sdk-core-1.12.576-sources.jar(/com/amazonaws/internal/ResettableInputStream.java):143 can occasionally use underscores as identifiers.

That's no longer valid after Java 9 and hinders any modern tooling that would want to parse your source code (e.g. for extracting useful info from its doc comments).

Expected Behavior

The Java source code is valid for JDK9+.

Current Behavior

It uses underscores as identifiers, and official tooling (e.g. javax.tools.DocumentationTool) will complain:

error: as of release 9, '_' is a keyword, and may not be used as an identifier

Reproduction Steps

Try running javac and/or other official JDK tools over your source code using a target version >= 9

Possible Solution

Update _ identifiers to e.g. _ignored

Additional Information/Context

No response

AWS Java SDK version used

1.12.576

JDK version used

openjdk version "16.0.1" 2021-04-20

Operating System and version

macOS

[debora-ito]

@vemv I understand the issue, I'll see if we can make the change in ResettableInputStream#mark.

That said, you don't need to compile the Java SDK code to be able to use it. The recommended way to consume the SDK is to add the modules as dependencies, as showed in the Developer Guide - https://docs.aws.amazon.com/sdk-for-java/v1/developer-guide/setup-project-maven.html#configuring-maven

<dependencies>
  <dependency>
    <groupId>com.amazonaws</groupId>
    <artifactId>aws-java-sdk-s3</artifactId>
  </dependency>
<dependency>

The SDK is compiled against JDK7, so you won't be blocked by this error when consuming as dependencies.

[vemv]

Thanks! Yes, I understand.

My issue is not created from the perspective of a SDK consumer but rather, from the perspective of a tooling maker.

My tooling parses source jars such as aws-java-sdk-core-1.12.576-sources.jar for IDE insights - so the source ideally would be valid.

[debora-ito]

@vemv We removed the underscore, the change is available in the latest release:

aws-sdk-java/aws-java-sdk-core/src/main/java/com/amazonaws/internal/ResettableInputStream.java

Line 143 in 9acdd7a

public void mark(int unused) {

[github-actions]

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

[vemv]

Thanks - appreciated!