Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade jscodeshift to v17.0.0 #957

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Downgrade jscodeshift to v17.0.0 #957

merged 2 commits into from
Oct 31, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 31, 2024

Issue

Fixes #956

Description

Downgrades jscodeshift to v17.0.0

Testing

CI

$ test-codemod> cat example.ts
import AWS from "aws-sdk";
const client = new AWS.DynamoDB();
const response = await client.listTables({}).promise();

$ test-codemod> ../aws-sdk-js-codemod/bin/aws-sdk-js-codemod -t v2-to-v3 example.ts 

╔════════════════════════════════════════════════════════╗
║ Please review the code change thoroughly for required  ║
║ functionality before deploying it to production.       ║
║                                                        ║
║ If the transformation is not complete or is incorrect, ║
║ please report the issue on GitHub.                     ║
╚════════════════════════════════════════════════════════╝

Processing 1 files... 
Spawning 1 workers...
Sending 1 files to free worker...
All done. 
Results: 
0 errors
0 unmodified
0 skipped
1 ok
Time elapsed: 0.263seconds 

$ test-codemod> cat example.ts 
import { DynamoDB } from "@aws-sdk/client-dynamodb";
const client = new DynamoDB();
const response = await client.listTables({});

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Oct 31, 2024

🦋 Changeset detected

Latest commit: 93d01d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
aws-sdk-js-codemod Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Oct 31, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/jscodeshift@17.0.0 Transitive: environment, filesystem, shell, unsafe +121 18.9 MB daniel15

🚮 Removed packages: npm/jscodeshift@17.1.0

View full report↗︎

@trivikr trivikr marked this pull request as ready for review October 31, 2024 20:42
@trivikr trivikr requested a review from a team as a code owner October 31, 2024 20:42
@trivikr trivikr merged commit 0057e41 into main Oct 31, 2024
7 checks passed
@trivikr trivikr deleted the downgrade-jscodeshift branch October 31, 2024 20:44
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws-sdk-js-codemod@2.4.0 throws error Cannot find module 'temp'
1 participant