fix: do not call next() twice (#1680)

aws · Nov 13, 2020 · 0964faf · 0964faf
1 parent eee41e8
commit 0964faf
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/packages/middleware-sdk-sqs/src/receive-message.ts b/packages/middleware-sdk-sqs/src/receive-message.ts
@@ -44,9 +44,7 @@ export function receiveMessageMiddleware(options: PreviouslyResolved): Initializ
       throw new Error("Invalid MD5 checksum on messages: " + messageIds.join(", "));
     }
 
-    return next({
-      ...args,
-    });
+    return resp;
   };
 }
 

diff --git a/packages/middleware-sdk-sqs/src/receive-messages.spec.ts b/packages/middleware-sdk-sqs/src/receive-messages.spec.ts
@@ -14,6 +14,22 @@ describe("receiveMessageMiddleware", () => {
     mockHashDigest.mockClear();
   });
 
+  it("should only call next once", async () => {
+    const next = jest.fn().mockReturnValue({
+      output: {
+        Messages: [
+          { Body: "foo", MD5OfBody: "00", MessageId: "fooMessage" },
+          { Body: "bar", MD5OfBody: "00", MessageId: "barMessage" },
+        ],
+      },
+    });
+    const handler = receiveMessageMiddleware({
+      md5: MockHash,
+    })(next, {} as any);
+    await handler({ input: {} });
+    expect(next).toBeCalledTimes(1);
+  });
+
   it("should do nothing if the checksums match", async () => {
     const next = jest.fn().mockReturnValue({
       output: {