fix(middleware-serde): mark error entry non-enumerable

aws · Mar 15, 2022 · 3e95763 · 3e95763
1 parent c411f8d
commit 3e95763
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/middleware-serde/src/deserializerMiddleware.spec.ts b/packages/middleware-serde/src/deserializerMiddleware.spec.ts
@@ -63,7 +63,7 @@ describe("deserializerMiddleware", () => {
     expect(mockDeserializer).toHaveBeenCalledWith(mockNextResponse.response, mockOptions);
   });
 
-  it("injects $response reference to deserializing exceptions", async () => {
+  it("injects non-enumerable $response reference to deserializing exceptions", async () => {
     const exception = Object.assign(new Error("MockException"), mockNextResponse.response);
     mockDeserializer.mockReset();
     mockDeserializer.mockRejectedValueOnce(exception);
@@ -73,6 +73,7 @@ describe("deserializerMiddleware", () => {
     } catch (e) {
       expect(e).toMatchObject(exception);
       expect(e.$response).toEqual(mockNextResponse.response);
+      expect(Object.keys(e)).not.toContain("$response");
     }
   });
 });
diff --git a/packages/middleware-serde/src/deserializerMiddleware.ts b/packages/middleware-serde/src/deserializerMiddleware.ts
@@ -22,6 +22,7 @@ export const deserializerMiddleware =
         output: parsed as Output,
       };
     } catch (error) {
-      throw Object.assign(error, { $response: response });
+      Object.defineProperty(error, "$response", { value: response, enumerable: false });
+      throw error;
     }
   };