Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The java codegen-ci is failing on main branch with error in method createSymbolProvider #2195

Closed
trivikr opened this issue Mar 30, 2021 · 2 comments · Fixed by #2196
Closed
Assignees
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Mar 30, 2021

Describe the bug

The java codegen-ci is failing on main branch with error: method createSymbolProvider in class TypeScriptCodegenPlugin cannot be applied to given types

Your environment

SDK version number

main branch

Is the issue in the browser/Node.js/ReactNative?

N/A

Details of the browser/Node.js/ReactNative version

N/A

Steps to reproduce

Run codegen-ci on main branch.
Example run in PR https://github.com/aws/aws-sdk-js-v3/pull/2194/checks?check_run_id=2228612186

Observed behavior

CI fails with error: method createSymbolProvider in class TypeScriptCodegenPlugin cannot be applied to given types

Expected behavior

CI succeeds

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 30, 2021
@trivikr trivikr self-assigned this Mar 30, 2021
@trivikr
Copy link
Member Author

trivikr commented Mar 30, 2021

The codegen-ci fails as:

Solutions:

  • Short-term: Pass settings wherever TypeScriptCodegenPlugin.createSymbolProvider is called.
  • Long-term: Publish smithy-typescript to maven and depend on it's specific version to avoid random CI failures.

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2021
Linkgoron pushed a commit to Linkgoron/aws-sdk-js-v3 that referenced this issue Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant