Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove @aws-sdk/url-parser-native in favor of react-native-url-polyfill #2229

Merged
merged 6 commits into from
Apr 12, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 9, 2021

Issue

Fixes: #2138

Description

Removes @aws-sdk/url-parser-native in favor of react-native-url-polyfill

Testing

React Native End2End testing is successful

Screen recording
react-native-url-polyfill-screen-recording.mov
Console output
$ node launch-app.js --local-publish
...
 PASS  e2e/End2EndTest.spec.js (23.327s)
  S3
    ✓ should upload an object after tapping putObject button (2318ms)
    ✓ after tapping getObject, App should get the same object that uploaded (1983ms)
    ✓ should list Objects after tapping listObjects button (1617ms)
    ✓ should conduct multipart upload after tapping createMultipartUpload, uploadPart, completeMultipartUpload buttons (3385ms)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7c53094). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 05b5ca6 differs from pull request most recent head fa48f63. Consider uploading reports for the commit fa48f63 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2229   +/-   ##
=======================================
  Coverage        ?   61.83%           
=======================================
  Files           ?      453           
  Lines           ?    23289           
  Branches        ?     5519           
=======================================
  Hits            ?    14401           
  Misses          ?     8888           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c53094...fa48f63. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: fa48f63
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr marked this pull request as ready for review April 12, 2021 19:02
@trivikr trivikr merged commit d6a67d7 into aws:main Apr 12, 2021
@trivikr trivikr deleted the remove-url-parser-native branch April 12, 2021 21:23
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use react-native-url-polyfill instead of deprecated url.parse in url-parser-native
4 participants