Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): generate and build generic client from private folder #2954

Merged
merged 4 commits into from
Oct 28, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 28, 2021

Issue

Fixes: #2939

History:

Description

Generates and builds generic client from private/aws-echo-service

Testing

CI generic-client-tests is successful.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title fix(ci): generate and build generic client in private folder fix(ci): generate and build generic client from private folder Oct 28, 2021
@trivikr trivikr marked this pull request as draft October 28, 2021 19:09
@trivikr trivikr marked this pull request as ready for review October 28, 2021 19:43
@AllanZhengYP AllanZhengYP merged commit 044a3ac into aws:main Oct 28, 2021
@trivikr trivikr deleted the update-generic-client-tests branch October 28, 2021 20:55
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Nov 1, 2021
)

* fix(ci): generate and build generic client from private folder

* fix(ci): run yarn before generating client

* chore: add script to build generic client

* chore: call build:clients:generic from geenric-client-tests
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The generic-client-tests CI does not pick up changes from monorepo
3 participants