Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prefix aws-protocoltests- for protocol test clients #2942

Merged
merged 6 commits into from
Oct 28, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 27, 2021

Issue

Issue: #2939

In step 1, we prefix aws-protocoltests- to protocol tests in current PR.
In step 2, the protocol_tests folder will be renamed to something else (say private).
In step 3, the generic client will be added in new folder and CI will be run on it.

Description

Adds prefix aws-protocoltests- for protocol test clients

Testing

Verified that yarn test:protocols was successful.

Additional context

The prefix protocoltests is used in Java path

{
"name": "includeServices",
"args": {
"services": ["aws.protocoltests.ec2#AwsEc2"]
}
}


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #2942 (ab046d8) into main (538d717) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2942   +/-   ##
=======================================
  Coverage   58.60%   58.60%           
=======================================
  Files         561      561           
  Lines       30272    30272           
  Branches     7452     7452           
=======================================
  Hits        17742    17742           
  Misses      12530    12530           
Impacted Files Coverage Δ
...sts/aws-protocoltests-ec2/src/EC2ProtocolClient.ts 92.00% <ø> (ø)
...c2/src/commands/EmptyInputAndEmptyOutputCommand.ts 100.00% <ø> (ø)
...tests-ec2/src/commands/EndpointOperationCommand.ts 81.81% <ø> (ø)
.../commands/EndpointWithHostLabelOperationCommand.ts 86.36% <ø> (ø)
...ests-ec2/src/commands/GreetingWithErrorsCommand.ts 95.45% <ø> (ø)
...s-ec2/src/commands/HostWithPathOperationCommand.ts 81.81% <ø> (ø)
...-ec2/src/commands/IgnoresWrappingXmlNameCommand.ts 95.45% <ø> (ø)
...ltests-ec2/src/commands/NestedStructuresCommand.ts 86.36% <ø> (ø)
...ltests-ec2/src/commands/NoInputAndOutputCommand.ts 95.45% <ø> (ø)
...c/commands/QueryIdempotencyTokenAutoFillCommand.ts 86.36% <ø> (ø)
... and 221 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 538d717...ab046d8. Read the comment docs.

@trivikr trivikr merged commit 0142e6b into aws:main Oct 28, 2021
@trivikr trivikr deleted the prefix-protocol-test branch October 28, 2021 16:46
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants