-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prefix aws-protocoltests-
for protocol test clients
#2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2021
AllanZhengYP
approved these changes
Oct 28, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue: #2939
In step 1, we prefix
aws-protocoltests-
to protocol tests in current PR.In step 2, the
protocol_tests
folder will be renamed to something else (sayprivate
).In step 3, the generic client will be added in new folder and CI will be run on it.
Description
Adds prefix
aws-protocoltests-
for protocol test clientsTesting
Verified that
yarn test:protocols
was successful.Additional context
The prefix
protocoltests
is used in Java pathaws-sdk-js-v3/codegen/protocol-test-codegen/smithy-build.json
Lines 6 to 11 in 538d717
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.