Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node-http-handler): resolve config provider only once per NodeHttpHandler instance #3545

Merged
merged 3 commits into from
Apr 20, 2022
Merged

fix(node-http-handler): resolve config provider only once per NodeHttpHandler instance #3545

merged 3 commits into from
Apr 20, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 14, 2022

Issue

#3279

Description

  • node-http-handler config can be an async provider
  • this PR modifies the handle method such that the async provider is only invoked once per instance

Testing

  • added unit tests for this scenario

@kuhe kuhe added the pr/needs-review This PR needs a review from a Member. label Apr 14, 2022
@kuhe kuhe requested a review from a team as a code owner April 14, 2022 18:48
@trivikr trivikr mentioned this pull request Apr 14, 2022
Merged
@kuhe kuhe merged commit 8ffd6b2 into aws:main Apr 20, 2022
@kuhe kuhe deleted the 3279-http-request-leak branch April 20, 2022 15:57
@kuhe kuhe linked an issue Apr 21, 2022 that may be closed by this pull request
Leaking file descriptors when generating too many http requests #3279
Closed
@kuhe kuhe removed a link to an issue Apr 21, 2022
Leaking file descriptors when generating too many http requests #3279
Closed
@kuhe kuhe mentioned this pull request Apr 21, 2022
Closed
keithalpichi pushed a commit to keithalpichi/aws-sdk-js-v3 that referenced this pull request Apr 23, 2022
@kuhe @keithalpichi
fix(node-http-handler): resolve config provider only once per NodeHtt…
6272451 
…pHandler instance (aws#3545)

* fix(node-http-handler): resolve config provider only once per NodeHttpHandler instance

* fix(node-http-handler): test synchronization update
@AllanZhengYP AllanZhengYP mentioned this pull request Apr 29, 2022
Merged
@github-actions
Copy link

github-actions bot commented May 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trivikr trivikr trivikr approved these changes

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees

@AllanZhengYP AllanZhengYP

Labels
pr/needs-review This PR needs a review from a Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuhe @AllanZhengYP @trivikr