chore(shared-ini-file-loader): use Promises in slurpFile hash #3546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
changed the title
AllanZhengYP
previously approved these changes
Apr 14, 2022
Contributor
AllanZhengYP
left a comment
AllanZhengYP
left a comment
There was a problem hiding this comment.
Looks good. We use the in the memoize() too, to handle concurrent calls.
kuhe
reviewed
Apr 14, 2022
trivikr
force-pushed
the
slurpfile-promise-hash
branch
from
3eaca88 to
9f4170a
Compare
kuhe
approved these changes
Apr 20, 2022
keithalpichi
pushed a commit
to keithalpichi/aws-sdk-js-v3
that referenced
this pull request
Apr 23, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Noticed that Promises can be resolved/rejected only once while reviewing #3545
Description
Uses Promises in slurpFile hash
Testing
Unit testing
Additional context
StackOverflow discussion https://codereview.stackexchange.com/a/51658
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.