Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typedoc to v0.23.x #4134

Closed
2 tasks
trivikr opened this issue Nov 1, 2022 · 9 comments
Closed
2 tasks

Bump typedoc to v0.23.x #4134

trivikr opened this issue Nov 1, 2022 · 9 comments
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue

Comments

@trivikr
Copy link
Member

trivikr commented Nov 1, 2022

Describe the feature

Bump typedoc to v0.23.x or latest

Use Case

There are bunch of dependabot alerts due to transitive dependencies of typedoc@0.19.x:

We use typedoc for generating our docs, and it's not shipped in SDK artifacts. These issues won't impact our customers directly, and won't slow down our documents generation as we own the generation as well as source code. However, they appear in our security tickets and reviews.

The typedoc@0.19.2 is also officially compatible only with typescript "3.9.x || 4.0.x", while our source code is on typescript 4.6.3. This can create issues with generation of docs.

Proposed Solution

Bump typedoc to v0.23.x or latest

Other Information

Prior internal discussions in JS-3393

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

main

Environment details (OS name and version, etc.)

N/A

@trivikr trivikr added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2022
@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2022

cc @eduardomourar who offered help with bumping typedoc in smithy-lang/smithy-typescript#563 (comment)

@trivikr trivikr added needs-triage This issue or PR still needs to be triaged. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Nov 1, 2022
@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2022

Previous attempt: #3712

The build had failed as PluginHost export was removed in TypeStrong/typedoc@22df574 which was released with v0.21.0. The plugins are now passed automatically.

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2022

The plugin we use for lerna typedoc-plugin-lerna-packages itself doesn't support typedoc@0.20.0
Issue being discussed in marcj/typedoc-plugin-lerna-packages#34

Typedoc added preliminary support for monorepos though in v0.21.x which we may have to evaluate https://github.com/TypeStrong/typedoc#monorepos--workspaces

@trivikr trivikr removed the needs-triage This issue or PR still needs to be triaged. label Nov 1, 2022
@eduardomourar
Copy link
Contributor

Created #4139 to help drive the discussion and the implementation itself.

@eduardomourar
Copy link
Contributor

eduardomourar commented Nov 2, 2022

We are leveraging the monorepo feature from typedoc as you mentioned. Find below the screenshots of the results:

  • Root project

root-after

  • Sample client

client-after

@eduardomourar
Copy link
Contributor

Keep in mind that I have been unable to run typedoc into the whole project due to this out of memory issue: TypeStrong/typedoc#1606

@eduardomourar
Copy link
Contributor

I believe the @aws-sdk/service-client-documentation-generator plugin (and possibly @aws-sdk/core-theme-documentation-generator) could be later removed by modifying the typescript codegen to include the categories tags.

Copy link

github-actions bot commented Nov 3, 2023

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Nov 3, 2023
@github-actions github-actions bot closed this as completed Nov 8, 2023
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants