Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump typedoc to 0.22.17 #3712

Closed
wants to merge 3 commits into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 17, 2022

Issue

Internal JS-3363

Description

Bumps typedoc to 0.22.17

Testing

ToDo

Additional context

Subset of #3701


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Jun 17, 2022

Build failure:

[build:es] src/index.ts:1:25 - error TS2305: Module '"typedoc/dist/lib/utils"' has no exported member 'PluginHost'.
[build:es] 
[build:es] 1 import { ParameterType, PluginHost } from "typedoc/dist/lib/utils";
[build:es]                           ~~~~~~~~~~
[build:es] 
[build:es] src/sdk-index-link-client.ts:5:32 - error TS2307: Cannot find module 'typedoc/dist/lib/output/models/NavigationItem' or its corresponding type declarations.
[build:es] 
[build:es] 5 import { NavigationItem } from "typedoc/dist/lib/output/models/NavigationItem";
[build:es]                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[build:es] 
[build:es] src/sdk-index-link-client.ts:35:12 - error TS2339: Property 'navigation' does not exist on type 'PageEvent<unknown>'.
[build:es] 
[build:es] 35       page.navigation = this.groupNavigation(page.navigation);
[build:es]               ~~~~~~~~~~
[build:es] 
[build:es] src/sdk-index-link-client.ts:35:51 - error TS2339: Property 'navigation' does not exist on type 'PageEvent<unknown>'.
[build:es] 
[build:es] 35       page.navigation = this.groupNavigation(page.navigation);
[build:es]                                                      ~~~~~~~~~~
[build:es] 
[build:es] src/sdk-index-link-client.ts:37:12 - error TS2339: Property 'navigation' does not exist on type 'PageEvent<unknown>'.
[build:es] 
[build:es] 37       page.navigation.children.filter(this.isClient).forEach((child) => {
[build:es]               ~~~~~~~~~~
[build:es] 
[build:es] src/sdk-index-link-client.ts:48:20 - error TS2339: Property '_skipRendering' does not exist on type 'unknown'.
[build:es] 
[build:es] 48     if (page.model._skipRendering) {
[build:es]                       ~~~~~~~~~~~~~~
[build:es] 
[build:es] 
[build:es] Found 6 errors in 2 files.
[build:es] 
[build:es] Errors  Files
[build:es]      1  src/index.ts:1
[build:es]      5  src/sdk-index-link-client.ts:5

Thrown in code

import { ParameterType, PluginHost } from "typedoc/dist/lib/utils";

@trivikr
Copy link
Member Author

trivikr commented Jun 17, 2022

In typedoc, PluginHost export was removed in TypeStrong/typedoc@22df574 which was released with v0.21.0, as plugins were passed automatically.

@trivikr
Copy link
Member Author

trivikr commented Jun 17, 2022

The plugin we use for lerna typedoc-plugin-lerna-packages itself doesn't support typedoc@0.20.0
Issue being discussed in marcj/typedoc-plugin-lerna-packages#34

Typedoc added preliminary support for monorepos though in https://github.com/TypeStrong/typedoc#monorepos--workspaces

@trivikr trivikr closed this Jun 17, 2022
@trivikr trivikr deleted the bump-typedoc branch June 17, 2022 19:48
@github-actions
Copy link

github-actions bot commented Jul 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant