@aws-sdk/node-config-provider should be a full dependency of @aws-sdk/config-resolver

[jfirebaugh]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

@aws-sdk/config-resolver lists @aws-sdk/node-config-provider as a devDependency, but depends on it for types, so it should be a full dependency.

This is the same as #4191 but with full reproduction steps.

SDK version number

@aws-sdk/config-resolver@3.272.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v16.17.1

Reproduction Steps

pnpm init
pnpm i @aws-sdk/client-secrets-manager typescript
echo "hoist=false" >.npmrc

tsconfig.json:

{
  "compilerOptions": {
    "lib": ["es2018", "dom"],
  }
}

index.ts:

import { SecretsManagerClient, GetSecretValueCommand } from '@aws-sdk/client-secrets-manager';

(async () => {
    const client = new SecretsManagerClient({ region: 'us-west-2' });
    const response = await client.send(new GetSecretValueCommand({
        SecretId: 'somekey'
    }))
    console.log(response)
})().then(console.log).catch(console.log)

Run pnpm tsc.

Observed Behavior

node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/endpointsConfig/NodeUseDualstackEndpointConfigOptions.d.ts:1:39 - error TS2307: Cannot find module '@aws-sdk/node-config-provider' or its corresponding type declarations.

1 import { LoadedConfigSelectors } from "@aws-sdk/node-config-provider";
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/endpointsConfig/NodeUseFipsEndpointConfigOptions.d.ts:1:39 - error TS2307: Cannot find module '@aws-sdk/node-config-provider' or its corresponding type declarations.

1 import { LoadedConfigSelectors } from "@aws-sdk/node-config-provider";
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/regionConfig/config.d.ts:1:59 - error TS2307: Cannot find module '@aws-sdk/node-config-provider' or its corresponding type declarations.

1 import { LoadedConfigSelectors, LocalConfigOptions } from "@aws-sdk/node-config-provider";
                                                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+middleware-retry@3.272.0/node_modules/@aws-sdk/middleware-retry/dist-types/configurations.d.ts:1:39 - error TS2307: Cannot find module '@aws-sdk/node-config-provider' or its corresponding type declarations.

1 import { LoadedConfigSelectors } from "@aws-sdk/node-config-provider";
                                        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+util-retry@3.272.0/node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1:91 - error TS2307: Cannot find module '@aws-sdk/types' or its corresponding type declarations.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, RetryToken, StandardRetryToken } from "@aws-sdk/types";
                                                                                            ~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+util-retry@3.272.0/node_modules/@aws-sdk/util-retry/dist-types/StandardRetryStrategy.d.ts:1:79 - error TS2307: Cannot find module '@aws-sdk/types' or its corresponding type declarations.

1 import { Provider, RetryErrorInfo, RetryStrategyV2, StandardRetryToken } from "@aws-sdk/types";
                                                                                ~~~~~~~~~~~~~~~~


Found 6 errors in 6 files.

Errors  Files
     1  node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/endpointsConfig/NodeUseDualstackEndpointConfigOptions.d.ts:1
     1  node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/endpointsConfig/NodeUseFipsEndpointConfigOptions.d.ts:1
     1  node_modules/.pnpm/@aws-sdk+config-resolver@3.272.0/node_modules/@aws-sdk/config-resolver/dist-types/regionConfig/config.d.ts:1
     1  node_modules/.pnpm/@aws-sdk+middleware-retry@3.272.0/node_modules/@aws-sdk/middleware-retry/dist-types/configurations.d.ts:1
     1  node_modules/.pnpm/@aws-sdk+util-retry@3.272.0/node_modules/@aws-sdk/util-retry/dist-types/AdaptiveRetryStrategy.d.ts:1
     1  node_modules/.pnpm/@aws-sdk+util-retry@3.272.0/node_modules/@aws-sdk/util-retry/dist-types/StandardRetryStrategy.d.ts:1

Expected Behavior

Compiles successfully.

Possible Solution

No response

Additional Information/Context

No response

[jfirebaugh]

@aws-sdk/middleware-retry has the same issue. https://github.com/aws/aws-sdk-js-v3/blob/main/packages/middleware-retry/package.json#L32

[spbarber]

@RanVaknin Is there a way around this in the meantime?

[troycarlson]

@spbarber pnpm supports patching package definitions via the pnpm.packageExtensions field in your package.json file, which will look something like this:

{
  name: "your project name",
  dependencies: {
    "@aws-sdk/client-s3": "^3.338.0"
  },
  "pnpm": {
    "packageExtensions": {
      "@aws-sdk/config-resolver": {
        "dependencies": {
          "@aws-sdk/node-config-provider": "*"
        }
      }
    }
  }
}

Which essentially tells pnpm to treat @aws-sdk/node-config-provider as a dependency of @aws-sdk/config-resolver (instead of a dev dependency). You can also specify versions and patch other attributes of packages you depend on, but this should solve the issue at hand.

[jfirebaugh]

@aws-sdk/middleware-endpoint-discovery has the same issue.

aws-sdk-js-v3/packages/middleware-endpoint-discovery/package.json

Line 24 in e5bc64e

"@aws-sdk/node-config-provider": "*",

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.