Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-sdk/client-dynamodb should be a full dependency of @aws-sdk/util-dynamodb #4876

Closed
3 tasks done
jfirebaugh opened this issue Jun 23, 2023 · 2 comments · Fixed by #5223
Closed
3 tasks done

@aws-sdk/client-dynamodb should be a full dependency of @aws-sdk/util-dynamodb #4876

jfirebaugh opened this issue Jun 23, 2023 · 2 comments · Fixed by #5223
Assignees
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@jfirebaugh
Copy link

Checkboxes for prior research

Describe the bug

@aws-sdk/util-dynamodb lists @aws-sdk/client-dynamodb as a devDependency, but imports it in public type definition files, so it should be a full dependency.

This is similar to #4481 and #4482. Please consider fixing them holistically, so that this class of issue does not recur in other context.

SDK version number

@aws-sdk/util-dynamodb@3.358.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.16.0

Reproduction Steps

pnpm init
pnpm i @aws-sdk/util-dynamodb typescript
echo "hoist=false" >.npmrc

tsconfig.json:

{
  "compilerOptions": {
    "lib": ["es2018", "dom"],
  }
}

index.ts:

import * as UtilDynamoDB from "@aws-sdk/util-dynamodb"

Run pnpm tsc.

Observed Behavior

node_modules/.pnpm/@aws-sdk+util-dynamodb@3.358.0/node_modules/@aws-sdk/util-dynamodb/dist-types/convertToAttr.d.ts:1:32 - error TS2307: Cannot find module '@aws-sdk/client-dynamodb' or its corresponding type declarations.

1 import { AttributeValue } from "@aws-sdk/client-dynamodb";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+util-dynamodb@3.358.0/node_modules/@aws-sdk/util-dynamodb/dist-types/convertToNative.d.ts:1:32 - error TS2307: Cannot find module '@aws-sdk/client-dynamodb' or its corresponding type declarations.

1 import { AttributeValue } from "@aws-sdk/client-dynamodb";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/.pnpm/@aws-sdk+util-dynamodb@3.358.0/node_modules/@aws-sdk/util-dynamodb/dist-types/marshall.d.ts:1:32 - error TS2307: Cannot find module '@aws-sdk/client-dynamodb' or its corresponding type declarations.

1 import { AttributeValue } from "@aws-sdk/client-dynamodb";
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~

Expected Behavior

Compiles successfully.

Possible Solution

No response

Additional Information/Context

No response

@jfirebaugh jfirebaugh added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2023
@RanVaknin RanVaknin self-assigned this Jun 23, 2023
@RanVaknin RanVaknin added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jun 23, 2023
@kuhe
Copy link
Contributor

kuhe commented Sep 15, 2023

in #5223 I'm moving it to peer first. We can move to a dependency later when doing the same for lib-dynamodb.

@kuhe kuhe self-assigned this Sep 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants