Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mode runtime shared config to own interface #490

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

AllanZhengYP
Copy link
Contributor

/cc @mtdowling
Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

clients/client-rds-data/RdsDataServiceClient.ts Outdated Show resolved Hide resolved
/**
* The function that will be used to populate serializing protocol
*/
protocol: string;

protocol?: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this and apiVersion optional?

clients/client-rds-data/RdsDataServiceClient.ts Outdated Show resolved Hide resolved
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #490 into smithy-codegen will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #490      +/-   ##
==================================================
- Coverage           94.54%   94.53%   -0.01%     
==================================================
  Files                  68       68              
  Lines                1284     1282       -2     
  Branches              256      255       -1     
==================================================
- Hits                 1214     1212       -2     
  Misses                 70       70
Impacted Files Coverage Δ
...ackages/node-http-handler/src/node-http-handler.ts 100% <0%> (ø) ⬆️
...ckages/node-http-handler/src/node-http2-handler.ts 89.65% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d17465f...16aace7. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP mentioned this pull request Dec 5, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 2a5dd77 into aws:smithy-codegen Dec 5, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented Dec 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants