Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: mode runtime shared config to own interface #490

Merged
merged 3 commits into from
Dec 5, 2019
Merged

feat: mode runtime shared config to own interface #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f04fb7a
feat: mode runtime shared config to own interface
AllanZhengYP Dec 4, 2019
56b206d
feat: add sharedConfig file for un-runtime default values
AllanZhengYP Dec 5, 2019
16aace7
fix: remove changes to rds data client
AllanZhengYP Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clients/client-rds-data/RdsDataServiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ import {
Client as SmithyClient,
SmithyResolvedConfiguration
} from "@aws-sdk/smithy-client";
import { HttpOptions as __HttpOptions } from "@aws-sdk/types";
import { HttpHandlerOptions as __HttpHandlerOptions } from "@aws-sdk/types";

export type ServiceInputTypes =
| RollbackTransactionRequest
Expand Down Expand Up @@ -158,7 +158,7 @@ export type RdsDataServiceConfig = RDSDataRuntimeDependencies &
UserAgentInputConfig;

export type RdsDataServiceResolvedConfig = SmithyResolvedConfiguration<
__HttpOptions
__HttpHandlerOptions
> &
Required<RDSDataRuntimeDependencies> &
AwsAuthResolvedConfig &
Expand All @@ -168,7 +168,7 @@ export type RdsDataServiceResolvedConfig = SmithyResolvedConfiguration<
UserAgentResolvedConfig;

export class RdsDataService extends SmithyClient<
__HttpOptions,
__HttpHandlerOptions,
ServiceInputTypes,
ServiceOutputTypes,
RdsDataServiceResolvedConfig
Expand Down
4 changes: 2 additions & 2 deletions clients/client-rds-data/commands/ExecuteStatementCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Command } from "@aws-sdk/smithy-client";
import { getSerdePlugin } from "@aws-sdk/middleware-serde";
import {
HttpOptions,
HttpHandlerOptions as __HttpHandlerOptions,
Handler,
HandlerExecutionContext,
FinalizeHandlerArguments,
Expand Down Expand Up @@ -32,7 +32,7 @@ export class ExecuteStatementCommand extends Command<
resolveMiddleware(
clientStack: MiddlewareStack<ServiceInputTypes, ServiceOutputTypes>,
configuration: RdsDataServiceResolvedConfig,
options?: HttpOptions
options?: __HttpHandlerOptions
): Handler<ExecuteStatementRequest, ExecuteStatementResponse> {
const { requestHandler } = configuration;

Expand Down
2 changes: 2 additions & 0 deletions packages/smithy-client/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import {

export interface SmithyConfiguration<HandlerOptions> {
requestHandler: RequestHandler<any, any, HandlerOptions>;
readonly apiVersion: string;
mtdowling marked this conversation as resolved.
Show resolved Hide resolved
readonly protocol: string;
}

export type SmithyResolvedConfiguration<HandlerOptions> = SmithyConfiguration<
Expand Down