Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump jest to 25.1.0 #1031

Merged
merged 4 commits into from
Mar 23, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Mar 23, 2020

Issue #, if available:
N/A

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b3aaafa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wouldn't dependabot handle this for us btw?

@trivikr
Copy link
Member Author

trivikr commented Mar 23, 2020

I'd asked dependabot to ignore updates for jest 25, as it needed testing #898 (comment)

Jest team was originally planning to condense the configuration down in v25, but have pushed it to v26 for now jestjs/jest#7185

@trivikr trivikr merged commit 878514d into aws:smithy-codegen Mar 23, 2020
@trivikr trivikr deleted the update-jest-25 branch March 23, 2020 17:25
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2020
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2020
@lock
Copy link

lock bot commented Apr 2, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants