Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: retry if retryable trait is set #1238

Merged
merged 8 commits into from
Jun 4, 2020
Merged

feat: retry if retryable trait is set #1238

merged 8 commits into from
Jun 4, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 3, 2020 •
edited
Loading

Issue #, if available:

Description of changes:
feat: retry if retryableTrait is set

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
chore: added SmithyException to SdkError
a7466a7
@trivikr
chore: add RetryableTrait to SmithyException
ac98741
@trivikr
fix: moved SdkError to @aws-sdk/smithy-client bec of dependency cycle
0117771 
erna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE @aws-sdk/types -> @aws-sdk/smithy-client -> @aws-sdk/types
lerna WARN ECYCLE @aws-sdk/middleware-stack -> (nested cycle: @aws-sdk/types -> @aws-sdk/smithy-client -> @aws-sdk/types) -> @aws-sdk/middleware-stack
lerna WARN ECYCLE (nested cycle: @aws-sdk/middleware-stack -> (nested cycle: @aws-sdk/types -> @aws-sdk/smithy-client -> @aws-sdk/types) -> @aws-sdk/middleware-stack) -> (nested cycle: @aws-sdk/middleware-stack -> (nested cycle: @aws-sdk/types -> @aws-sdk/smithy-client -> @aws-sdk/types) -> @aws-sdk/middleware-stack)
@trivikr
chore: codegen for adding retryable in Error
836f1d1
@trivikr
feat: check for $retryable.throttling in isThrottlingError
6243fd4
@trivikr
feat: add isRetryableByTrait in service-error-classification
46a74c2
@trivikr
Revert "chore: codegen for adding retryable in Error"
3ef26cf 
This reverts commit 836f1d1.
@trivikr trivikr mentioned this pull request Jun 3, 2020
Merged
@trivikr trivikr changed the title feat: retry if retryableTrait is set feat: retry if retryable trait is set Jun 3, 2020
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
AllanZhengYP
AllanZhengYP reviewed Jun 3, 2020
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean now the ExponentialBackoffStrategy comply to the retryable traits? Or alternatively we need to create a new retry strategy class complying the new retry design?

packages/middleware-retry/package.json Outdated Show resolved Hide resolved
@trivikr
Copy link
Member Author

trivikr commented Jun 3, 2020

Does it mean now the ExponentialBackoffStrategy comply to the retryable traits?

Yes.

alternatively we need to create a new retry strategy class complying the new retry design?

No. The new "standard" retry strategy will replace "legacy" as standard in v3.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 74bb5d7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr force-pushed the modeled-retries-retryable branch from 74bb5d7 to 8780d26 Compare June 4, 2020 03:25
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 8780d26
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit 9d224e7 into aws:master Jun 4, 2020
@trivikr trivikr deleted the modeled-retries-retryable branch June 4, 2020 14:23
@trivikr trivikr mentioned this pull request Jul 9, 2020
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @aws-sdk-js-automation @AllanZhengYP