-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(credential-provider-imds): update httpGet to accept options.method #1353
feat(credential-provider-imds): update httpGet to accept options.method #1353
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1353 +/- ##
==========================================
+ Coverage 77.67% 77.69% +0.01%
==========================================
Files 286 287 +1
Lines 11955 11979 +24
Branches 2623 2627 +4
==========================================
+ Hits 9286 9307 +21
- Misses 2669 2672 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice +1
@@ -29,6 +29,7 @@ | |||
"@types/jest": "^26.0.4", | |||
"@types/node": "^10.0.0", | |||
"jest": "^26.1.0", | |||
"nock": "^13.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer adding the dev dependency to the project root, just like all the E2E test dependencies. Doing so can reduce the number dependencies user needs to download.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Required for PUT operation in signed IMDS workflow (internal JS-1903)
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.