Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-provider-imds): signed IMDS workflow #1358

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 10, 2020

Issue #, if available:
Internal JS-1903

Description of changes:
signed IMDS workflow

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2020

Codecov Report

Merging #1358 into master will increase coverage by 0.07%.
The diff coverage is 97.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1358      +/-   ##
==========================================
+ Coverage   79.00%   79.07%   +0.07%     
==========================================
  Files         287      287              
  Lines       11112    11150      +38     
  Branches     2350     2358       +8     
==========================================
+ Hits         8779     8817      +38     
  Misses       2333     2333              
Impacted Files Coverage Δ
packages/abort-controller/src/AbortController.ts 100.00% <ø> (ø)
packages/abort-controller/src/AbortSignal.ts 100.00% <ø> (ø)
...-provider-cognito-identity/src/IndexedDbStorage.ts 19.14% <0.00%> (ø)
...ges/eventstream-marshaller/src/HeaderMarshaller.ts 100.00% <ø> (ø)
.../eventstream-marshaller/src/TestVectors.fixture.ts 100.00% <ø> (ø)
...sal/src/fixtures/MockEventMessageSource.fixture.ts 86.95% <ø> (ø)
...tream-serde-universal/src/getUnmarshalledStream.ts 80.76% <ø> (ø)
packages/hash-blob-browser/src/index.ts 100.00% <ø> (ø)
packages/middleware-header-default/src/index.ts 90.90% <ø> (ø)
packages/middleware-host-header/src/index.ts 80.00% <ø> (ø)
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7b79cb...907dc07. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@trivikr trivikr marked this pull request as draft July 13, 2020 16:48
@trivikr
Copy link
Member Author

trivikr commented Jul 13, 2020

Converted to draft, as it would need rebase after lint PR is merged #1367

@trivikr trivikr force-pushed the signed-imds-workflow-prettified branch from 196edd4 to 907dc07 Compare July 13, 2020 18:30
@trivikr trivikr marked this pull request as ready for review July 13, 2020 18:30
@trivikr
Copy link
Member Author

trivikr commented Jul 13, 2020

Moved to ready for review, as it's rebased form master, linted and conflicts resolved.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve.

@trivikr trivikr merged commit 954ff24 into aws:master Jul 13, 2020
@trivikr trivikr deleted the signed-imds-workflow-prettified branch July 13, 2020 18:49
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants