Compatibility with Webpack 5 #1503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my Next.js project I am migrating to webpack 5. I get the following error that on my side is not possible to fix:
``Should not import the named export 'name' (imported as 'name') from default-exporting module (only default export is available soon)``
In the documentation page from webpack "To v5 from v4" the following is mentioned:
``Using named exports from JSON modules: this is not supported by the new specification and you will get a warning. Instead of import { version } from './package.json' use import package from './package.json'; const { version } = package;``
This should fix the error not just for me but also for others who are attempting:
vercel/next.js#13341 (comment)
|
Created an issue at #1504, as it's a warning and not an error when bundling JS SDK v3 |
trivikr
requested changes
Sep 8, 2020
fix for error TS1214: Identifier expected. 'package' is a reserved word in strict mode.
trivikr
requested changes
Sep 8, 2020
Fix for error TS1259: Module can only be default-imported using the 'esModuleInterop' flag
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
- Coverage 79.80% 79.77% -0.04%
==========================================
Files 298 299 +1
Lines 11502 11805 +303
Branches 2475 2483 +8
==========================================
+ Hits 9179 9417 +238
- Misses 2323 2388 +65
Continue to review full report at Codecov.
|
|
Super-ceded by #1505 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my Next.js project I am migrating to webpack 5. I get the following error that on my side is not possible to fix:
Should not import the named export 'name' (imported as 'name') from default-exporting module (only default export is available soon)In the documentation page from webpack "To v5 from v4" the following is mentioned:
Using named exports from JSON modules: this is not supported by the new specification and you will get a warning. Instead of import { version } from './package.json' use import package from './package.json'; const { version } = package;This should fix the error not just for me but also for others who are attempting:
vercel/next.js#13341 (comment)