-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node-http-handler): throw TimeoutError for Node.js timeouts #1693
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1693 +/- ##
==========================================
- Coverage 79.77% 79.70% -0.08%
==========================================
Files 325 329 +4
Lines 12087 12576 +489
Branches 2553 2671 +118
==========================================
+ Hits 9643 10024 +381
- Misses 2444 2552 +108
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor comment
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue #, if available:
Fixes: #1196
Description of changes:
This PR throws TimeoutError for Node.js timeouts (
"ECONNRESET"
,"EPIPE"
,"ETIMEDOUT"
), so that retryMiddleware can retry them.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.