Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Sigv4 for non AWS services #2385

Merged
merged 7 commits into from
Jun 3, 2021
Merged

feat: support Sigv4 for non AWS services #2385

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6dc029
feat(middleware-signing): support SigV4 for non AWS services
gosar May 11, 2021
3b3ae92
feat(codegen): support SigV4 for non AWS services
gosar May 11, 2021
6bf272c
fix(codegen): use Region plugin explicitly for AWS service
gosar May 13, 2021
bd25fda
chore(clients): update clients with updates for SigV4 for non AWS ser…
gosar May 13, 2021
1b9be32
test(middleware-signing): add test for non AWS service SigV4
gosar May 13, 2021
494c044
chore(codegen): reduce duplication for writing region
gosar May 25, 2021
36fcace
Reverting unnecessary changes to protocol tests
gosar Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/client-accessanalyzer/AccessAnalyzerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are basically going back what the comment was before some of my earlier changes. See

aws-sdk-js-v3/clients/client-accessanalyzer/AccessAnalyzerClient.ts

Line 229 in 9ab71e8

* The AWS region to which this client will send requests

*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-acm-pca/ACMPCAClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-acm/ACMClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-alexa-for-business/AlexaForBusinessClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-amp/AmpClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-amplify/AmplifyClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-amplifybackend/AmplifyBackendClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-api-gateway/APIGatewayClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-apigatewaymanagementapi/ApiGatewayManagementApiClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-apigatewayv2/ApiGatewayV2Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-app-mesh/AppMeshClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-appconfig/AppConfigClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-appflow/AppflowClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-appintegrations/AppIntegrationsClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-application-auto-scaling/ApplicationAutoScalingClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-application-discovery-service/ApplicationDiscoveryServiceClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-application-insights/ApplicationInsightsClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-appstream/AppStreamClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-appsync/AppSyncClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-athena/AthenaClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-auditmanager/AuditManagerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-auto-scaling-plans/AutoScalingPlansClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-auto-scaling/AutoScalingClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-backup/BackupClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-batch/BatchClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-braket/BraketClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-budgets/BudgetsClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-chime/ChimeClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloud9/Cloud9Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-clouddirectory/CloudDirectoryClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudformation/CloudFormationClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudfront/CloudFrontClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudhsm-v2/CloudHSMV2Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudhsm/CloudHSMClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudsearch-domain/CloudSearchDomainClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudsearch/CloudSearchClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudtrail/CloudTrailClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudwatch-events/CloudWatchEventsClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudwatch-logs/CloudWatchLogsClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-cloudwatch/CloudWatchClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-codeartifact/CodeartifactClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-codebuild/CodeBuildClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-codecommit/CodeCommitClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
2 changes: 1 addition & 1 deletion clients/client-codedeploy/CodeDeployClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ export interface ClientDefaults extends Partial<__SmithyResolvedConfiguration<__
serviceId?: string;

/**
* The AWS region to which this client will send requests or use as signingRegion
* The AWS region to which this client will send requests
*/
region?: string | __Provider<string>;

Expand Down
Loading