Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsconfig): define workspace specific compilerOptions #2812

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 22, 2021

Issue

Noticed while working on #2799

Description

Define workspace specific compilerOptions in lib-*

Testing

Verified that following values are present in root tsconfig.cjs.json

    "strict": true,
    "sourceMap": false,
    "declaration": true,
    "importHelpers": true,
    "noEmitHelpers": true,
    "inlineSourceMap": true,
    "inlineSources": true,

We're using default for stringInternal

Verified that following values are present in root tsconfig.es.json

    "strict": true,
    "sourceMap": false,
    "declaration": true,
    "importHelpers": true,
    "noEmitHelpers": true,
    "inlineSourceMap": true,
    "inlineSources": true,

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2812 (8bf562e) into main (a7f843a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2812   +/-   ##
=======================================
  Coverage   60.41%   60.41%           
=======================================
  Files         554      554           
  Lines       28883    28883           
  Branches     7076     7076           
=======================================
  Hits        17450    17450           
  Misses      11433    11433           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7f843a...8bf562e. Read the comment docs.

@trivikr trivikr merged commit 1cfbe28 into aws:main Sep 22, 2021
@trivikr trivikr deleted the lib-tsconfig branch September 22, 2021 21:37
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants