Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clients): update clients as of 10/07/2021 #2879

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Follow up: #2857

Description

Update clients as of 10/07/2021


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from trivikr October 7, 2021 23:02
@codecov-commenter
Copy link

Codecov Report

Merging #2879 (a732829) into main (7f5567b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2879   +/-   ##
=======================================
  Coverage   58.57%   58.57%           
=======================================
  Files         558      558           
  Lines       30249    30249           
  Branches     7443     7443           
=======================================
  Hits        17719    17719           
  Misses      12530    12530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5567b...a732829. Read the comment docs.

@AllanZhengYP
Copy link
Contributor Author

The CodeBuild failed by the transient issue that we did not mock the date very well:

Summary of all failing tests
FAIL packages/signature-v4/src/SignatureV4.spec.ts (14.946 s)
  ● SignatureV4 › ambient Date usage › should use the current date for signing if no signing date supplied

    expect(received).toBe(expected) // Object.is equality

    Expected: "20211007T231337Z"
    Received: "20211007T231336Z"

      724 |     it("should use the current date for signing if no signing date supplied", async () => {
      725 |       const { headers } = await signer.sign(minimalRequest);
    > 726 |       expect(headers[AMZ_DATE_HEADER]).toBe(iso8601(new Date()).replace(/[\-:]/g, ""));
          |                                        ^
      727 |     });
      728 |   });
      729 | });

      at src/SignatureV4.spec.ts:726:40
      at step (src/SignatureV4.spec.ts:44:23)
      at Object.next (src/SignatureV4.spec.ts:25:53)
      at fulfilled (src/SignatureV4.spec.ts:16:58)

Merge this PR and we will put a separate PR for fixing the SigV4 unit test

/cc @trivikr

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants