Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Mar 24, 2022

Issue

Refs: #3469

Description

Removes profile specific data from providers.

Testing

  • ToDo: Unit testing
  • ToDo: Integration testing
  • ToDo: Manual testing to ensure there are only two readFile calls.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner March 24, 2022 21:52
@trivikr trivikr marked this pull request as draft March 24, 2022 22:55
@trivikr trivikr force-pushed the update-shared-config-init branch from 4da18b9 to 32fac22 Compare March 24, 2022 22:56
@trivikr trivikr changed the title fix(node-config-provider): remove profile specific data from fromSharedConfigFiles chore: remove profile specific data from providers Mar 24, 2022
@trivikr
Copy link
Member Author

trivikr commented Mar 24, 2022

Superceded by #3478

@trivikr trivikr closed this Mar 24, 2022
@trivikr trivikr deleted the update-shared-config-init branch March 24, 2022 23:35
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant