Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RetryStrategy class and retryMiddleware implementation #389

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

AllanZhengYP
Copy link
Contributor

Put retry logic into RetryStrategy itself. Keep retryMiddleware minimal.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP added the smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch label Oct 9, 2019
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

Merging #389 into smithy-codegen will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           smithy-codegen     #389      +/-   ##
==================================================
+ Coverage           96.97%   96.97%   +<.01%     
==================================================
  Files                  69       69              
  Lines                1156     1158       +2     
  Branches              211      213       +2     
==================================================
+ Hits                 1121     1123       +2     
  Misses                 35       35
Impacted Files Coverage Δ
packages/retry-middleware/src/defaultStrategy.ts 100% <100%> (ø) ⬆️
packages/retry-middleware/src/retryMiddleware.ts 77.77% <100%> (-14.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033f953...f1ee764. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 0cf9213 into aws:smithy-codegen Oct 15, 2019
@lock
Copy link

lock bot commented Oct 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
smithy-codegen Changes regarding supporting smithy model. Will be merged to smithy-codegen branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants