fix(karma-credential-loader): karma Preprocessor may support promises #403
Conversation
Karma before 4.3 only supported callbacks, after 4.4 now will support returning a promise. Since the function is `async` if it does not return the result, then the undefined value of the promise may be preferred over the callback.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@seebees Is this still needed? karma-runner/karma#3383 (comment) |
|
It is not needed. (karma-runner/karma#3387) But I think that having an async function that returns its result in the callback is a little counterintuitive. |
trivikr
force-pushed
the
master
branch
2 times, most recently
from
f2fdf2e
to
4a23bb4
Compare
|
The master branch will soon be replaced by our So I will close this for now because it's no longer applicable. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Karma before 4.3 only supported callbacks,
after 4.4 now will support returning a promise.
Since the function is
asyncif it does not return the result,then the undefined value of the promise may be preferred over the callback.
see: karma-runner/karma#3383
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.