Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update uuid to v9 #4397

Merged
merged 1 commit into from
Feb 14, 2024
Merged

chore(deps): update uuid to v9 #4397

merged 1 commit into from
Feb 14, 2024

Conversation

yoyoonarock
Copy link
Contributor

@yoyoonarock yoyoonarock commented Feb 3, 2023

Issue

#3964

Description

  • Update uuid to v9.0.1
  • Update @types/uuid to v9.0.4

Testing

Wasn't able to test this locally cause my computer is super slow, hoping PR checks will run tests for me

Additional context

uuid v9.0.0 removes the need for a workaround for a moduleNameMapper or custom resolver when mocking in Jest.

Related PR: microsoft/accessibility-insights-web#5421 (comment)

First time contributing, so happy to take feedback or help out however I can


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yoyoonarock yoyoonarock requested review from a team as code owners February 3, 2023 05:24
@vherr2
Copy link

vherr2 commented Feb 3, 2023

❤️

@aleksclark
Copy link

any word on this?

@kachkaev kachkaev mentioned this pull request May 15, 2023
2 tasks
@diogotorres97
Copy link

this would be awesome 🙏 we have a few workarounds because of jest and using uuid v8...

@yoyoonarock yoyoonarock changed the title chore(deps): update uuid to v9.0.0 chore(deps): update uuid to v9 Sep 23, 2023
@trivikr trivikr merged commit df49359 into aws:main Feb 14, 2024
@trivikr trivikr mentioned this pull request Feb 14, 2024
2 tasks
@yoyoonarock yoyoonarock deleted the bump-uuid-v9 branch February 26, 2024 07:45
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants