chore(packages): consolidate middleware integ tests #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Jun 18, 2023
kuhe
reviewed
Jun 18, 2023
srchase
force-pushed
the
consolidate-middleware-integ-tests
branch
from
3926653
to
cfa8405
Compare
srchase
force-pushed
the
consolidate-middleware-integ-tests
branch
from
cfa8405
to
b46bc03
Compare
kuhe
approved these changes
Jun 30, 2023
kuhe
requested changes
Jun 30, 2023
| "build:types": "tsc -p tsconfig.types.json", | ||
| "build:types:downlevel": "downlevel-dts dist-types dist-types/ts3.4", | ||
| "clean": "rimraf ./dist-* && rimraf *.tsbuildinfo", | ||
| "test": "jest --coverage --passWithNoTests" |
There was a problem hiding this comment.
these tests need to run in the test:integration classification, because they import undeclared fully built clients.
kuhe
approved these changes
Jun 30, 2023
This was referenced Jul 3, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
This PR moves the integration tests from the following packages into a consolidated
aws-middleware-testpackage:Testing
Ran
yarn testfrom the new package.Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.