fix(util-retry): correct attempts count on StandardRetryStrategy #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Jun 27, 2023
srchase
force-pushed
the
fix-max-attempts
branch
2 times, most recently
from
71150a7 to
ac14d76
Compare
syall
suggested changes
Jun 27, 2023
srchase
force-pushed
the
fix-max-attempts
branch
from
ac14d76 to
397b004
Compare
syall
approved these changes
Jun 27, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
This PR fixes the attempts count used in
StandardRetryStrategyinutil-retry. The number of attempts made is one more than the number of retries. The correct attempts count is then used to compare againstmaxAttemptsto determine if retries should be made.This corrects the behavior of
StandardRetryStrategyto be congruent with the documentation here: https://docs.aws.amazon.com/sdkref/latest/guide/feature-retry-behavior.htmlTesting
Updated tests to cover case where max attempts is set to 1 which should disable any retries.
Additional context
Add any other context about the PR here.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.