Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): skip emitting warning for Node.js 14.x #6044

Merged
merged 1 commit into from
May 1, 2024
Merged

chore(core): skip emitting warning for Node.js 14.x #6044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/client/emitWarningIfUnsupportedVersion.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe("emitWarningIfUnsupportedVersion", () => {
process.emitWarning = emitWarning;
});

describe(`emits warning for Node.js <${supportedVersion}`, () => {
describe.skip(`emits warning for Node.js <${supportedVersion}`, () => {
const getPreviousMajorVersion = (major: number) => (major === 0 ? 0 : major - 1);

const getPreviousMinorVersion = ([major, minor]: [number, number]) =>
Expand Down
15 changes: 8 additions & 7 deletions packages/core/src/client/emitWarningIfUnsupportedVersion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ let warningEmitted = false;
export const emitWarningIfUnsupportedVersion = (version: string) => {
if (version && !warningEmitted && parseInt(version.substring(1, version.indexOf("."))) < 16) {
warningEmitted = true;
process.emitWarning(
`NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
no longer support Node.js 14.x on May 1, 2024.
// ToDo: Turn back warning for future Node.js version deprecation
// process.emitWarning(
// `NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
// no longer support Node.js 14.x on May 1, 2024.

To continue receiving updates to AWS services, bug fixes, and security
updates please upgrade to an active Node.js LTS version.
// To continue receiving updates to AWS services, bug fixes, and security
// updates please upgrade to an active Node.js LTS version.

More information can be found at: https://a.co/dzr2AJd`
);
// More information can be found at: https://a.co/dzr2AJd`
// );
}
};
Loading