Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(middleware-expect-continue): do not set expect header if using FetchHttpHandler #6046

Merged
merged 1 commit into from
May 8, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 1, 2024

Issue

this is incidentally noticed while testing smithy-lang/smithy-typescript#1256

Description

skip the expect header if the requestHandler is fetch, which doesn't like that header.

Testing

CI integration tests

@kuhe kuhe requested a review from a team as a code owner May 1, 2024 18:43
@kuhe kuhe force-pushed the feat/fetch-in-node branch from 5e8425d to a89a3b0 Compare May 2, 2024 13:42
@kuhe kuhe force-pushed the feat/fetch-in-node branch from a89a3b0 to d071a40 Compare May 6, 2024 16:44
@kuhe kuhe merged commit 6bb0904 into aws:main May 8, 2024
5 checks passed
@kuhe kuhe deleted the feat/fetch-in-node branch May 8, 2024 15:12
siddsriv pushed a commit to siddsriv/aws-sdk-js-v3 that referenced this pull request May 8, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants