fix(credential-provider-ini): pass clientConfig to sso and sso-oidc inner clients #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
commented
Nov 22, 2024
| @@ -1,23 +1,18 @@ | |||
| const ssoOidcClientsHash: Record<string, any> = {}; | |||
There was a problem hiding this comment.
I removed this caching functionality. Credentials are cached already, there should be no need to cache the client as well. Caching the client conflicts with being able to configure the client, since this cache exposes no method to clear it.
siddsriv
reviewed
Nov 22, 2024
siddsriv
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
addresses #6687
Description
This change ensures
clientConfig, a property shared by many credential providers, is used as the initialization config for all inner clients including SSO and SSOOIDC. Currently, it is only passed through for CognitoIdentity and STS clients.Testing
manual SSO testing